Repository navigation
feat(deploy): refuse host-side agents unless explicitly allowed - #140
Merged
Merged
Conversation
- The server refuses FRONTAL_CODE_SERVER_LANE_TRANSPORT=tools-agent unless FRONTAL_CODE_SERVER_ALLOW_HOST_AGENT=1 is set. local-docker stays the default. - Managed deploy configs (Fly, Kubernetes, Terraform, deploy.yaml) set the opt-in, because their VM or pod is the isolation boundary. - The compose default is local-docker. It needs the docker-worker override for the socket proxy. - docs/CONTAINERS.md describes the default and the opt-in. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools-agent(agents inside the server process, with its privileges) is refused unlessFRONTAL_CODE_SERVER_ALLOW_HOST_AGENT=1is set.local-dockerstays the default.deploy/deploy.yaml.local-docker. That path needs the docker-worker override, which provides the socket proxy.docs/CONTAINERS.mddescribes the default and the opt-in.Verification
cargo fmt --check,cargo clippy -D warnings, andcargo test -p code-serverpass.tools-agentneeds the opt-in, andlocal-dockerdoesn't.Note: independent of #139 (medium-priority fixes). Both touch
lib.rsin separate areas.🤖 Generated with Claude Code